Open
Conversation
Tests verify that the compose→commit IME flow does not produce duplicate characters on the terminal screen (issue connectbot/connectbot#1955). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
super.commitText() internally calls finishComposingText(), which cleared composingText before the backspace guard could execute. This caused composed text to be sent during setComposingText() and then sent again by commitText() without erasing the first copy. Save composingText before calling super.commitText() so the backspace guard correctly removes the previously composed text. Fixes connectbot/connectbot#1955 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The tests created a TerminalEmulator with a no-op onKeyboardInput callback, so dispatched characters were never echoed back to the terminal display, resulting in blank screen output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Instead of looping keyboard output back into writeInput (which doesn't handle BS/DEL correctly since VT100 cursor-back doesn't erase characters), capture the onKeyboardInput bytes and compute the effective text by applying BS/DEL as erasure operations. Also set isComposeModeActive=true so BaseInputConnection uses fullEditor mode (no duplicate key event dispatch from commitText). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Now CI is passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix on-screen keyboards duplicating every character (connectbot/connectbot#1955)
Test plan