Skip to content

add Matter-2021-96#1515

Open
FredericBlum wants to merge 2 commits intomasterfrom
Matter-2021-96
Open

add Matter-2021-96#1515
FredericBlum wants to merge 2 commits intomasterfrom
Matter-2021-96

Conversation

@FredericBlum
Copy link
Copy Markdown
Collaborator

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

Adding a new conceptlist that is used in a Comparative Cariban Database. Its mostly the Swadesh-1996-100a list, minus four concepts, and remapped four of them, so this should be fairly quick and non-polemic.

@AnnikaTjuka Can you do moderate the PR? @RebeccaLethgo Can do the review if necessary.

@AnnikaTjuka
Copy link
Copy Markdown
Collaborator

Sure, I can moderate. @RebeccaLethgo and @MiraAhmedovic Would you have time to review the PR?

Copy link
Copy Markdown
Collaborator

@MiraAhmedovic MiraAhmedovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this list @FredericBlum!
I left one comment concerning the current list and another request for fixing an older typo in conceptlists.tsv, if you'd be so kind.

@FredericBlum
Copy link
Copy Markdown
Collaborator Author

Fixed and added. Catched some more typos on the way.

@RebeccaLethgo is currently on vacations and can probably do the review in two weeks. But we are in no hurry here.

Copy link
Copy Markdown
Collaborator

@AnnikaTjuka AnnikaTjuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the list and correcting the spelling errors, @FredericBlum. I’ve had a look at the PR and as it’s a straightforward list, a single review should suffice. @MiraAhmedovic Could you please approve your requested changes so that @FredericBlum can merge the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants