Add sourcekit-lsp initialization smoke test#706
Draft
z2oh wants to merge 1 commit intocompnerd:mainfrom
Draft
Conversation
compnerd
reviewed
Jan 18, 2024
| "capabilities": {}, | ||
| "trace": "verbose", | ||
| } | ||
| } No newline at end of file |
Owner
There was a problem hiding this comment.
Missing newline at the end of the file?
Contributor
Author
There was a problem hiding this comment.
I'll have to test if including one breaks the test. There's not supposed to be a newline at the end of the RPC message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure of the best place to add the initialization request message. Because of the specific format of the message (must be CLRF; must be precise byte-length) it seemed difficult to inline into the GHA. I added a new
testsdir with the file there, but I am reluctant to clutter the repo root. Is there a better place to put this?