Handle R_X86_64_JUMP_SLOT with addend and guard empty CFGs#47
Open
rupeshkoushik07 wants to merge 1 commit intocolumbia:masterfrom
Open
Handle R_X86_64_JUMP_SLOT with addend and guard empty CFGs#47rupeshkoushik07 wants to merge 1 commit intocolumbia:masterfrom
rupeshkoushik07 wants to merge 1 commit intocolumbia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Summary
calloc + 28454) as data references using ExternalSymbolLinkDetails
A relocation like
R_X86_64_JUMP_SLOT calloc@@GLIBC_2.2.5 + 28454means "resolve calloc, then add 28454 bytes." Previously unhandled, causing an exception. When addend is non-zero, the target is a data reference, not a function call.The empty CFG guard prevents a crash in
SccOrder::genFull(0)when iterating over all functions including those from dependency libraries that were not fully disassembled.