DRYD-2052: Update jaxb plugin and schemas#517
Open
mikejritter wants to merge 58 commits intocollectionspace:upgrade/dryd-1633-core-updatesfrom
Open
DRYD-2052: Update jaxb plugin and schemas#517mikejritter wants to merge 58 commits intocollectionspace:upgrade/dryd-1633-core-updatesfrom
mikejritter wants to merge 58 commits intocollectionspace:upgrade/dryd-1633-core-updatesfrom
Conversation
Contributor
Author
|
@spirosdi if this is too big I'm sure we can find a way to split it up to be more manageable; most of the changes were just find/replace though so no big logic. Maybe something like plugin configuration -> base jaxb module -> collectionobject + procedures -> authorities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2052
This is an update to the classes which are created through the jaxb-maven-plugin. It allows them to use jakarta imports.
I updated the dependencies in the jaxb modules as appropriate to try and remove any redundant/unnecessary dependencies. Some which required
AbstractCommonListwill still depend onorg.collectionspace.services.jaxb, but others only specifyjakarta.xml.bind-apiandjaxb-plugins-runtime. Likewise some of the authority jaxb modules still requireorg.collectionspace.services.authority.jaxb.How should this be tested? Do these changes have associated tests?
This is a bit tricky because the project still does not compile. A few things can be done to spot check the changes:
grep -lr --include '*.xsd' 'http://java.sun.com'at the root of the repository will show all files which still reference it.notemodule is also included in here, but the module is not used in compilation at all. We should probably remove it.mvn generate-sourcescompletes successfullyfind . -wholename '*/target/generated-sources/*'org.collectionspace.services.jaxbmodule will complete. In that case, amvn installmight need to be done in that module.Dependencies for merging? Releasing to production?
Many changes still to be done for production :)
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter has been testing locally
Have any new security vulnerabilities been handled?
n/a