-
Notifications
You must be signed in to change notification settings - Fork 85
Update the default HTTP client to httpx-aiohttp (httpx with aiohttp transport) insted of httpx.AsyncClient for better concurrency
#746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samuel-cahyawijaya
wants to merge
3
commits into
main
Choose a base branch
from
samuel/httpx-aiohttp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| """ | ||
| Run chat twice: once with the SDK default async HTTP stack (HttpxAiohttpClient), | ||
| once with an explicit httpx.AsyncClient. | ||
|
|
||
| Requires CO_API_KEY in the environment. Optional: CO_MODEL (defaults to command-r-plus). | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import asyncio | ||
| import os | ||
| import sys | ||
|
|
||
| import httpx | ||
|
|
||
| from cohere import AsyncClient | ||
|
|
||
|
|
||
| def _api_key() -> str: | ||
| key = os.getenv("CO_API_KEY") | ||
| if not key: | ||
| print("Set CO_API_KEY to your Cohere API key.", file=sys.stderr) | ||
| sys.exit(1) | ||
| return key | ||
|
|
||
|
|
||
| def _model() -> str: | ||
| return os.getenv("CO_MODEL", "command-a-03-2025") | ||
|
|
||
|
|
||
| async def chat_default_httpx_aiohttp() -> None: | ||
| """Uses the SDK default (aiohttp-backed HttpxAiohttpClient).""" | ||
| async with AsyncClient(api_key=_api_key()) as client: | ||
| inner = client._client_wrapper.httpx_client.httpx_client | ||
| print(f"default inner client: {type(inner).__module__}.{type(inner).__name__}") | ||
| response = await client.chat(message="Hello", model=_model()) | ||
| print("default — reply:", (response.text or "")[:200]) | ||
|
|
||
|
|
||
| async def chat_custom_httpx() -> None: | ||
| """Uses a caller-provided httpx.AsyncClient.""" | ||
| custom = httpx.AsyncClient(timeout=120.0) | ||
| try: | ||
| async with AsyncClient(api_key=_api_key(), httpx_client=custom) as client: | ||
| inner = client._client_wrapper.httpx_client.httpx_client | ||
| print(f"custom inner client: {type(inner).__module__}.{type(inner).__name__}") | ||
| assert inner is custom | ||
| response = await client.chat(message="Hello", model=_model()) | ||
| print("custom — reply:", (response.text or "")[:200]) | ||
| finally: | ||
| # Context manager already closed `custom` when using httpx_client=; this is a no-op if closed. | ||
| if not custom.is_closed: | ||
| await custom.aclose() | ||
|
|
||
|
|
||
| async def main() -> None: | ||
| await chat_default_httpx_aiohttp() | ||
| await chat_custom_httpx() | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| asyncio.run(main()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top-level import forces aiohttp for sync-only users
Medium Severity
The
from httpx_aiohttp import HttpxAiohttpClientimport is at the module top level, unconditionally executed whenbase_client.pyis loaded. Sinceclient.pyimportsBaseCohereandAsyncBaseCoherefrom this module, andcohere.__init__imports fromclient.py, anyimport cohere— even for purely sync usage viacohere.Client— triggers loading ofhttpx_aiohttpand transitively all ofaiohttp(including its C extensions).HttpxAiohttpClientis only used insideAsyncBaseCohere.__init__, so the import could be deferred there or placed behindtyping.TYPE_CHECKINGwith a lazy import at the call site.