Issue #145 deal with main background and navbar being the same colour#151
Open
Games4Doritos wants to merge 1 commit intomainfrom
Open
Conversation
- Removed roundedness to the navbar border, this is to stay consistent with the sharp, non-rounded style of the website (we can discuss if you disagree) - Added a width for the navbar's bottom border - Changed the navbar's background colour from background to landingCard, which will contrast better with the pages and not blend in with the background like previously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This pr just has a few changes to improve the navbar's styling and to also fulfil the issue. Some of this may be subjective so feel free to request something else.
This is what it looks like in contrast to the main background:
Change Form
Related issue