fix: prevent error message corruption during scrolling#66
Open
romanstingler wants to merge 1 commit intocodersauce:masterfrom
Open
fix: prevent error message corruption during scrolling#66romanstingler wants to merge 1 commit intocodersauce:masterfrom
romanstingler wants to merge 1 commit intocodersauce:masterfrom
Conversation
- Preserve error messages during scroll actions (ScrollUp/ScrollDown) - Force error line to be included in render diff to prevent artifacts - Skip bottom-right corner cell to prevent terminal scrolling - Clean newlines from error messages and ensure proper width - Fix scroll boundary check (< instead of <=) - Add lifetime annotation to Change struct for better memory safety The issue was that scrolling would corrupt the error display because
Contributor
|
Whoa, is this a new year's gift? Just when I thought this project was abandoned for good 😄 I will review this shortly and let you know! |
Contributor
Contributor
|
Feedback from Codex:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The issue was that scrolling would corrupt the error display because
