Skip to content

⚡️ Speed up method CodeCommitProvider._is_valid_codecommit_hostname by 68% #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method CodeCommitProvider._is_valid_codecommit_hostname by 68% #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pr_agent/git_providers/codecommit_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
from ..log import get_logger
from .git_provider import GitProvider

_CODECOMMIT_HOSTNAME_PATTERN = re.compile(r"^[a-z]{2}-(gov-)?[a-z]+-\d\.console\.aws\.amazon\.com$")


class PullRequestCCMimic:
"""
Expand Down Expand Up @@ -359,7 +361,7 @@ def _is_valid_codecommit_hostname(hostname: str) -> bool:
Returns:
- bool: True if the hostname is valid, False otherwise.
"""
return re.match(r"^[a-z]{2}-(gov-)?[a-z]+-\d\.console\.aws\.amazon\.com$", hostname) is not None
return _CODECOMMIT_HOSTNAME_PATTERN.match(hostname) is not None

def _get_pr(self):
response = self.codecommit_client.get_pr(self.repo_name, self.pr_num)
Expand Down