⚡️ Speed up function _get_all_json_refs by 91.64%#312
Open
codeflash-ai[bot] wants to merge 1 commit intomainfrom
Open
⚡️ Speed up function _get_all_json_refs by 91.64%#312codeflash-ai[bot] wants to merge 1 commit intomainfrom
_get_all_json_refs by 91.64%#312codeflash-ai[bot] wants to merge 1 commit intomainfrom
Conversation
The `_get_all_json_refs` function was rewritten from recursive traversal to an iterative stack-based approach, achieving a 91% speedup (2.42ms → 1.26ms). Recursive calls in Python incur significant overhead from frame allocation and teardown on each nested dict/list, whereas the stack-based version amortizes this cost across the entire traversal with a single while-loop. The optimization is especially effective on deeply nested JSON schemas where recursive depth would trigger many function calls, now replaced by simple list append/extend operations.
codeflash-ai
bot
added
⚡️ codeflash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 91.64% (0.92x) speedup for
_get_all_json_refsinsrc/algorithms/search.py⏱️ Runtime :
2.42 milliseconds→1.26 milliseconds(best of171runs)📝 Explanation and details
The
_get_all_json_refsfunction was rewritten from recursive traversal to an iterative stack-based approach, achieving a 91% speedup (2.42ms → 1.26ms). Recursive calls in Python incur significant overhead from frame allocation and teardown on each nested dict/list, whereas the stack-based version amortizes this cost across the entire traversal with a single while-loop. The optimization is especially effective on deeply nested JSON schemas where recursive depth would trigger many function calls, now replaced by simple list append/extend operations.✅ Correctness verification report:
To edit these changes
git checkout codeflash/optimize-_get_all_json_refs-mnho62qeand push.