Merged
Conversation
…havior PR #1968 changed JS to skip nested functions like Python, but the parity test still expected JS to discover both outer and inner. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Claude finished @mohammedahmed18's task in 2m 0s —— View job PR Review SummaryTriageSMALL — 1 test file changed, 14 lines total (4 added, 10 removed). Prek ChecksAll checks passed (ruff format, ruff lint). No issues. Code ReviewThe change is correct and straightforward. PR #1968 updated JS discovery to skip nested functions (matching Python behavior), and this PR updates the parity test to reflect that. Changes look good:
No bugs, security issues, or breaking changes detected. Duplicate DetectionNo duplicates detected — this is a targeted test update for a behavior change already merged. Test CoverageN/A — this PR only modifies tests, no production code changed. Last updated: 2026-04-02T19:05:30Z |
Saga4
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outerandinnertest_nested_functions_discoveryto assert both languages discover only the outer functionTest plan
test_nested_functions_discoverypasses locally🤖 Generated with Claude Code