Skip to content

fix: update nested functions parity test#1976

Merged
Saga4 merged 1 commit intomainfrom
fix/nested-functions-parity-test
Apr 2, 2026
Merged

fix: update nested functions parity test#1976
Saga4 merged 1 commit intomainfrom
fix/nested-functions-parity-test

Conversation

@mohammedahmed18
Copy link
Copy Markdown
Contributor

Summary

Test plan

  • test_nested_functions_discovery passes locally

🤖 Generated with Claude Code

…havior

PR #1968 changed JS to skip nested functions like Python, but the parity
test still expected JS to discover both outer and inner.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 2, 2026

Claude finished @mohammedahmed18's task in 2m 0s —— View job


PR Review Summary

Triage

SMALL — 1 test file changed, 14 lines total (4 added, 10 removed).

Prek Checks

All checks passed (ruff format, ruff lint). No issues.

Code Review

The change is correct and straightforward. PR #1968 updated JS discovery to skip nested functions (matching Python behavior), and this PR updates the parity test to reflect that.

Changes look good:

  • Docstring updated from "JavaScript discovers them with parent info" → "Both Python and JavaScript skip nested functions"
  • Removed assertions about JS finding 2 functions (outer + inner) and checking parent info
  • Added assertion that JS (like Python) finds only 1 function (outer)

No bugs, security issues, or breaking changes detected.

Duplicate Detection

No duplicates detected — this is a targeted test update for a behavior change already merged.

Test Coverage

N/A — this PR only modifies tests, no production code changed.


Last updated: 2026-04-02T19:05:30Z

@mohammedahmed18 mohammedahmed18 requested review from KRRT7 and Saga4 April 2, 2026 19:05
@Saga4 Saga4 merged commit b0c4e1f into main Apr 2, 2026
28 of 30 checks passed
@Saga4 Saga4 deleted the fix/nested-functions-parity-test branch April 2, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants