Reapply FontAwesome v4 to v7 codemod output with fixes#71572
Open
levadadenys wants to merge 7 commits intostagingfrom
Open
Reapply FontAwesome v4 to v7 codemod output with fixes#71572levadadenys wants to merge 7 commits intostagingfrom
levadadenys wants to merge 7 commits intostagingfrom
Conversation
levadadenys
requested review from
Copilot and
lfryemason
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reapplies/adjusts the FontAwesome v4→v7 codemod changes and fixes a handful of icon usages in progress-related UI components and JsDebugger styling.
Changes:
- Updates
SendLessonand its unit test to use the newershare-from-squareicon. - Updates progress teacher info and related story data to newer icon names.
- Adds additional styling rules intended to improve the JsDebugger resize bar icon presentation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/test/unit/templates/progress/SendLessonTest.js | Updates the expected icon name for the SendLesson button. |
| apps/style/JsDebuggerUi.scss | Attempts to adjust resize bar icon styling via nested i rules. |
| apps/src/templates/progress/SendLesson.jsx | Changes the button icon name and attempts to set icon style. |
| apps/src/templates/progress/ProgressLessonTeacherInfo.story.jsx | Updates assessment icon string used in story fixtures. |
| apps/src/templates/progress/ProgressLessonTeacherInfo.jsx | Updates lesson feedback button icon name. |
| apps/src/code-studio/components/progress/UnitCalendarGrid.jsx | Updates legend icon name and attempts to specify regular style. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
levadadenys
added a commit
that referenced
this pull request
Mar 23, 2026
This reverts the changes from PR #71572 which reapplied the FontAwesome v4 to v7 codemod migration with fixes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
lfryemason
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProgressLessonTeacherInfoandSendLessoncomponentsJsDebuggerUi.scssTest plan
🤖 Generated with Claude Code