Fix some unexpected behavior for thrift field mask.#362
Open
Fix some unexpected behavior for thrift field mask.#362
Conversation
678b7c8 to
da2b3ce
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 67.50% 67.89% +0.39%
==========================================
Files 88 88
Lines 25044 25404 +360
==========================================
+ Hits 16905 17249 +344
- Misses 8139 8155 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
da2b3ce to
6508ffc
Compare
961d69f to
1cfc4b4
Compare
1cfc4b4 to
d4cacf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix some unexpected behavior for thrift field mask.
Required fields gated by field mask
Pilota-generated code checks
_field_mask.field(id)for ALL fields, includingrequiredones. If the field mask selects
$.some_struct.optional_fieldbut not$.some_struct.required_field, the requiredrequired_fieldfield is omitted from the output.Scalar not treated as all fields while map encoding
set_field_mask(fm)propagates a scalar (leaf) FieldMask to each map value struct's_field_maskfield. A scalar FM has no field-level children, so all inner fields are gated and NOT serialized.Solution