Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new constructor
new_with_capacity, which mimics theVec::with_capacityAPI. I shamelessly stole almost all the documentation from Rust 🤓Choices made:
with_capacity, but because we must instantiate with an element I leaned towards a name that differentiated itself to avoid confusion and landed onnew_with_capacity. No strong feelings on this and happy to change.capacityrefers to the size of theNonEmptystruct as though it were aVec. This is sort of a weird one, but there are two motivations.NonEmpty. The mental model ofNonEmptyis that it's aVecbut always has at least one element in it. Because we require a value when constructing aNonEmptyvec, the size must always be at least 1 even though internally thetailVecwill be empty.capacityto always be at least one matches the existing behavior ofNonEmpty::capacity, which returns (roughly)1 + tail.len().