Conversation
Member
Author
|
Ughhh I just wasn't looking in the right file. They are in nats-tls-wrapper.stderr.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nats has stopped logging. Again. There is an old issue about this here: #66. It was fixed, but for some reason the fix is no longer working.
In this PR I explicitly set the log file in the nats config. If we ever got rid of the nats-wrapper and started nats by bpm directly we would not need to do this (I think).
The new nats log is named:
nats.log.Backward Compatibility
This changes the name of the nats logs (when it used to log at all). I think this is okay and does not need to be considered a breaking change.