modernize ASP.NET Core samples by erwinkramer · Pull Request #326 · cloudevents/sdk-csharp

erwinkramer · 2026-03-13T13:17:28Z

This modernizes the ASP.NET Core samples in a couple of ways:

Minimal API's instead of controllers
slnx instead of sln solution
ASP.NET Core 10
IBindableFromHttpContext to bind an incoming CloudEvent, instead of controller based Microsoft.AspNetCore.Mvc.Formatters
SystemTextJson instead of NewtonsoftJson
Reduced complexity of the GenerateCloudEvent method by using the native CopyToHttpResponseAsync from CloudNative.CloudEvents.AspNetCore

Successful build @ https://github.com/erwinkramer/sdk-csharp/actions/runs/23054867045

jskeet · 2026-03-13T13:30:25Z

Just to set expectations, I'll look at this when I can, but it's unlikely to be for at least a week.

erwinkramer · 2026-03-13T14:22:51Z

test/CloudNative.CloudEvents.IntegrationTests/CloudNative.CloudEvents.IntegrationTests.csproj


  <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" VersionOverride="10.0.5" /> <!-- VersionOverride is needed to avoid pulling in a later version of Microsoft.AspNetCore.App that isn't compatible with .NET 10.0. -->


I could convert the whole repo into .NET 10 in a successive PR, so we don't suffer from tricks like this. I'm not sure how much impact that has yet, so I refrained from making this current change too big.

We still want to support .NET 8 while that's a supported platform. We may be able to target net8 while using the .NET 10 SDK, but I definitely don't want to remote a net8 target.

You'd like to keep net8 on the IntegrationTests and AspNetCoreSample projects as well?

Not sure, and I don't have the bandwidth to think about it right now. Leave this comment thread open, and I'll reply again when I get round to reviewing the whole PR.

Okay, I've thought about it more - I'm fine with this being net10.0 only, and likewise IntegrationTests. I want to keep the production code projects targeting net8.0 for now. We can add a target for net10.0 (in a separate PR) so that we can remove net8.0 when it goes EOL.

The VersionOverride is still in there for now. If I'd have to remove it (and bump the directory package version to 10), I have to modify the GitHub workflow to only run tests on .NET 10, right? Not sure if you want that at this stage.

test/CloudNative.CloudEvents.IntegrationTests/AspNetCore/CloudEventBindingTests.cs

erwinkramer · 2026-03-13T14:34:28Z

Thanks for your quick heads-up @jskeet. I think the PR is ready to go and I'm happy to continue on some other maintenance work related to this repo, in successive PRs.

samples/CloudNative.CloudEvents.AspNetCoreSample/CloudEventJsonInputFormatter.cs

jskeet · 2026-03-30T17:24:24Z

samples/CloudNative.CloudEvents.AspNetCoreSample/CloudEventOperations.cs

+using System.Collections.Generic;
+using System.Threading.Tasks;
+
+namespace CloudNative.CloudEvents.AspNetCoreSample.Operations


Let's use a file-scoped namespace for new code.

And if this is in a different namespace, please move it to the corresponding folder. (Does it need to be in a different namespace?)

Changed to file-scoped for the samples (including HttpSend sample). For the namespace, I'm not sure if it's worth it to keep a distinct namespace. For simplicity's sake I changed the whole project as CloudNative.CloudEvents.AspNetCoreSample namespace for now, otherwise binding and operations files would each have their own namespace and folder, which is maybe a little too much for those 2 files.

That sounds fine to me.

samples/CloudNative.CloudEvents.AspNetCoreSample/CloudEventOperations.cs

samples/CloudNative.CloudEvents.AspNetCoreSample/CloudEventBinding.cs

jskeet · 2026-03-30T17:27:12Z

global.json

@@ -1,6 +1,6 @@
 {
  "sdk": {
-    "version": "8.0.400",


Adding this comment here, but basically I'd quite like to keep all the "general infrastructure update" changes separate from the sample changes. If I create a PR that makes these changes separately, are you happy to rebase on top of that? (The PR itself will be simple, but I'll need to get it reviewed of course.)

sure, go for it

I guess that would include the sln to slnx migration from this PR as well?

Yup, that was my thinking.

See #327 - I'm hoping I can get that reviewed and merged this week.

test/CloudNative.CloudEvents.IntegrationTests/AspNetCore/CloudEventBindingTests.cs

samples/CloudNative.CloudEvents.AspNetCoreSample/CloudEventJsonInputFormatter.cs

jskeet · 2026-03-30T17:32:41Z

samples/CloudNative.CloudEvents.AspNetCoreSample/CloudEventBinding.cs

+
+    public ProblemHttpResult Error { get; init; }
+
+    public static async ValueTask<CloudEventBinding> BindAsync(HttpContext context, ParameterInfo parameter)


Just as a heads-up, I'm really not familiar with IBindableFromHttpContext. I'm mostly following along, but I could easily miss things.

samples/CloudNative.CloudEvents.AspNetCoreSample/Program.cs

jskeet · 2026-03-30T17:38:58Z

test/CloudNative.CloudEvents.IntegrationTests/CloudNative.CloudEvents.IntegrationTests.csproj


  <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" VersionOverride="10.0.5" /> <!-- VersionOverride is needed to avoid pulling in a later version of Microsoft.AspNetCore.App that isn't compatible with .NET 10.0. -->


Okay, I've thought about it more - I'm fine with this being net10.0 only, and likewise IntegrationTests. I want to keep the production code projects targeting net8.0 for now. We can add a target for net10.0 (in a separate PR) so that we can remove net8.0 when it goes EOL.

jskeet · 2026-03-31T16:38:08Z

Infrastructure PR now merged, so you should be able to rebase onto it.

Signed-off-by: Erwin <erwinkramer@hotmail.com>

- Convert .sln to .slnx - Update to .NET 10 SDK - Update unit test targets to net8.0 and net10.0 - Update integration test target to net10.0 - Update sample targets to net10.0 - Update all dependencies as far as they're compatible - Update protobuf generator and regenerate - Update actions/setup-dotnet workflow action Signed-off-by: Jon Skeet <skeet@pobox.com> Signed-off-by: Erwin <erwinkramer@hotmail.com>

Signed-off-by: Erwin <erwinkramer@hotmail.com>

This reverts commit f305671. Signed-off-by: Erwin <erwinkramer@hotmail.com>

erwinkramer · 2026-03-31T17:40:19Z

@jskeet I guess it's ready to be merged now.

jskeet · 2026-03-31T17:47:19Z

I'll have another look when I can - maybe tomorrow evening, but it may be Friday.

Signed-off-by: Erwin <erwinkramer@hotmail.com>

erwinkramer marked this pull request as ready for review March 13, 2026 13:19

erwinkramer force-pushed the main branch from f248705 to 7fcc710 Compare March 13, 2026 13:22

erwinkramer marked this pull request as draft March 13, 2026 13:32

erwinkramer force-pushed the main branch from f03260a to 6461da0 Compare March 13, 2026 14:19

erwinkramer commented Mar 13, 2026

View reviewed changes

erwinkramer marked this pull request as ready for review March 13, 2026 14:32

erwinkramer commented Mar 13, 2026

View reviewed changes

samples/CloudNative.CloudEvents.AspNetCoreSample/CloudEventJsonInputFormatter.cs Show resolved Hide resolved

erwinkramer force-pushed the main branch 3 times, most recently from 2ca5aaa to 5cccd96 Compare March 13, 2026 18:57

jskeet reviewed Mar 30, 2026

View reviewed changes

erwinkramer and others added 16 commits March 31, 2026 19:23

.net 10

3277dc1

Signed-off-by: Erwin <erwinkramer@hotmail.com>

.net 10

262f7f9

Signed-off-by: Erwin <erwinkramer@hotmail.com>

minimal api approach

c56f814

Signed-off-by: Erwin <erwinkramer@hotmail.com>

use system.text.json

cf42e8d

Signed-off-by: Erwin <erwinkramer@hotmail.com>

leverage CopyToHttpResponseAsync

44f7a51

Signed-off-by: Erwin <erwinkramer@hotmail.com>

streamlining

17d743a

Signed-off-by: Erwin <erwinkramer@hotmail.com>

system.text for httpsend

227a2a1

Signed-off-by: Erwin <erwinkramer@hotmail.com>

sdk fix

a4cf801

Signed-off-by: Erwin <erwinkramer@hotmail.com>

rollback framework version for test projects

e3d4bc7

Signed-off-by: Erwin <erwinkramer@hotmail.com>

rollback csharp reference

63540da

Signed-off-by: Erwin <erwinkramer@hotmail.com>

fix integration tests

fc900e3

Signed-off-by: Erwin <erwinkramer@hotmail.com>

structured and binary mode improvements

f0997a0

Signed-off-by: Erwin <erwinkramer@hotmail.com>

some global testing packages updates

f1f4d95

Signed-off-by: Erwin <erwinkramer@hotmail.com>

allow for content-less via binary mode for CloudEventBinding

6044561

Signed-off-by: Erwin <erwinkramer@hotmail.com>

single line jsonOptions

cec2d05

Signed-off-by: Erwin <erwinkramer@hotmail.com>

static cloudEventOperations

f496b08

Signed-off-by: Erwin <erwinkramer@hotmail.com>

erwinkramer and others added 6 commits March 31, 2026 19:23

copyright

140b9a3

Signed-off-by: Erwin <erwinkramer@hotmail.com>

streamline namespace usage in samples

f05a373

Signed-off-by: Erwin <erwinkramer@hotmail.com>

Linq for getting attributes

34f356f

Signed-off-by: Erwin <erwinkramer@hotmail.com>

drop version override for testing lib

587f867

Signed-off-by: Erwin <erwinkramer@hotmail.com>

Revert "drop version override for testing lib"

6637372

This reverts commit f305671. Signed-off-by: Erwin <erwinkramer@hotmail.com>

erwinkramer force-pushed the main branch from 562977e to 6637372 Compare March 31, 2026 17:32

Merge branch 'main' into main

b6eeea3

revert enter on packages props

c5a16b0

Signed-off-by: Erwin <erwinkramer@hotmail.com>


		public ProblemHttpResult Error { get; init; }

		public static async ValueTask<CloudEventBinding> BindAsync(HttpContext context, ParameterInfo parameter)

Conversation

erwinkramer commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jskeet commented Mar 13, 2026

Uh oh!

erwinkramer Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erwinkramer commented Mar 13, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jskeet commented Mar 31, 2026

Uh oh!

erwinkramer commented Mar 31, 2026

Uh oh!

jskeet commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

erwinkramer commented Mar 13, 2026 •

edited

Loading

erwinkramer Mar 13, 2026 •

edited

Loading