Enhanced GPM-GT integration in application process#112
Draft
Conversation
Collaborator
Author
|
@setiadha-unc has indicated that this may be close to ready (with some potential ongoing discussions for rationale for tiers in GCEP application), so I've rebased against main and opened a draft pull request for review. |
bpow
commented
Jan 9, 2026
|
|
||
| namespace App\DataTransferObjects; | ||
|
|
||
| class GtDiseaseDto |
Collaborator
Author
There was a problem hiding this comment.
For safety, DTO classes should probably be final readonly. I'd also be interested into looking into use of a FromArrayTrait or Spatie's DataTransferObject library to see if we can make DTO classes more concisely (not just these, but for others in the codebase as well.
bpow
commented
Jan 9, 2026
| return [ | ||
| 'ids' => 'required|array|min:1', | ||
| 'ids.*' => 'required|integer|exists:genes,id', | ||
| 'tier' => 'nullable|integer|in:1,2,3,4' |
Collaborator
Author
There was a problem hiding this comment.
Is this correct anymore? I think we had changed to having just 2 tiers.
bpow
commented
Jan 9, 2026
| return this.genes.reduce((n, g) => { return n + ((this.getTier(g) === 1 && this.isCurated(g)) ? 1 : 0); }, 0); | ||
| }, | ||
| shouldShowRationale() { | ||
| return this.group?.is_gcep && (this.tier1CuratedGenesCount > 0 || this.editing); |
Collaborator
Author
There was a problem hiding this comment.
Double checking the logic here: do we want the rationale to be shown when editing even if there are no tier1 curated genes?
bpow
force-pushed
the
gpm-gt-epam-integration
branch
3 times, most recently
from
465a36b to
08fe4e3
Compare
bpow
force-pushed
the
gpm-gt-epam-integration
branch
from
08fe4e3 to
d270813
Compare
bpow
force-pushed
the
gpm-gt-epam-integration
branch
3 times, most recently
from
141f27b to
c3f3c93
Compare
setiadha-unc
force-pushed
the
gpm-gt-epam-integration
branch
from
4142a92 to
902bd05
Compare
bpow
force-pushed
the
gpm-gt-epam-integration
branch
from
902bd05 to
9f9464d
Compare
setiadha-unc
force-pushed
the
gpm-gt-epam-integration
branch
2 times, most recently
from
d59083f to
88ed058
Compare
bpow
force-pushed
the
gpm-gt-epam-integration
branch
from
0a71a27 to
a5d68d0
Compare
setiadha-unc
force-pushed
the
gpm-gt-epam-integration
branch
from
b189056 to
6280a47
Compare
setiadha-unc
force-pushed
the
gpm-gt-epam-integration
branch
from
4151176 to
5dc9e5b
Compare
…coordinators. Fixed GPM-GT-Integration
…ption. GPM integration to GT.
… Fix GPM-GT Integration
…or scope and rationale. no DTO. GPM-GT-Epam-Integration
… rename table genes to scope_genes. GPM-GT-Epam-Integration
…include in checkpoint. Fix GPM-GT-Integration
…apshot. GPM-GT-Integration
…PM-GT Integration
setiadha-unc
force-pushed
the
gpm-gt-epam-integration
branch
from
5dc9e5b to
51c38bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to multiple JIRA issues: https://broadinstitute.atlassian.net/jira/software/projects/GPM/boards/828?selectedIssue=GPM-500 and dependent on https://broadinstitute.atlassian.net/browse/GT-70.