Open
Conversation
- remove broadcast channel overrides which always just did the same thing - use shouldPublish to indication publishability (since GroupEvent already inherits from this now) - removed lots of un-used `use`s
TODO: - more tests - fire some event when description is updated - maybe there should be a similar generic "GroupAttributesUpdated" event - why not just use model observation for this?
as long as we're cleaning up the dx messages, trying to make things more consistent by making event name be based on class name (for the most part) by actually using reflection to do so.
behavior of GroupEvents is that they are by default published for non-EPs or for EPs that have had step 1 approval. events that are internal enough to not warrant publishing to DX now need to override shouldPublish to return false
bpow
force-pushed
the
next-main-202502
branch
2 times, most recently
from
0c54f63 to
4ca4f51
Compare
… HTML - update dompurify to current-- no longer MSIE compatible, but neither is vue3 - has a command to update existing markdown descriptions to HTML... - liberal sprinklings of dompurify...
…utes replaces the commit in #105
There must be a better way to do this (avoiding cyclical updates of content changes, so watcher is run, which might change content), but this at least seems to work for now. There's still something weird going on from the CSS/layout standpoint with the box sometimes getting bigger as things are typed into it...
bpow
force-pushed
the
next-main-202502
branch
3 times, most recently
from
1053bb6 to
d35787d
Compare
…s...) addresses GPM-487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a much longer branch than I'd like because there ended up being several interacting things that needed to be updated and/or otherwise addressed together: