Fix Notion login prompt for custom domain users#72
Merged
Conversation
Previously, page fetches forwarded the original request.headers (including Host header from the custom domain) to Notion. This caused Notion to return a login page instead of public content for *.notion.site users. Use explicit PAGE_FETCH_HEADERS with standard user-agent, accept, and accept-language headers, matching the pattern already used for API endpoint fetches. Fixes #55 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PAGE_FETCH_HEADERSinstead of forwardingrequest.headerswhen fetching page content from NotionHost: <custom-domain>) were forwarded to Notion, causing it to return a login page instead of public content for*.notion.siteusers/api/*)Fixes #55
Test plan
*.notion.siteusers/api/*) are unaffected (already using clean headers)npm run build)