change oracle slashing to be checked every few hours#628
Open
StrathCole wants to merge 3 commits intomainfrom
Open
change oracle slashing to be checked every few hours#628StrathCole wants to merge 3 commits intomainfrom
StrathCole wants to merge 3 commits intomainfrom
Conversation
StrathCole
requested review from
TropicalDog17,
Copilot,
hoank101 and
kien6034
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements an early slashing mechanism for the oracle module that proactively penalizes validators who have exceeded the miss threshold and cannot recover to meet the minimum valid vote rate by the end of the current SlashWindow. This improves protocol security by taking action against non-performing validators sooner rather than waiting for the full slash window to complete.
Key Changes:
- Introduced
SlashExceedingMissCountersmethod that identifies and slashes validators who have mathematically exceeded the recovery threshold - Modified
SlashAndResetMissCountersto call the new method before resetting counters, consolidating slashing logic - Added periodic early slashing check every 7200 blocks (~12 hours) in the EndBlocker
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| x/oracle/keeper/slash.go | Implements the new SlashExceedingMissCounters method with early slashing logic and refactors SlashAndResetMissCounters to use it |
| x/oracle/abci.go | Adds conditional check to invoke early slashing every 7200 blocks (~12 hours) in addition to the end-of-window slashing |
| x/oracle/keeper/slash_test.go | Adds comprehensive test coverage for the new early slashing functionality with edge cases for bonded, unbonded, and jailed validators |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
StrathCole
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an early slashing mechanism for validators in the oracle module who have already exceeded the maximum allowed missed votes and cannot recover within the current SlashWindow. This allows the system to penalize non-performing validators sooner, improving protocol security and responsiveness.
Early Slashing Mechanism:
SlashExceedingMissCountersto the keeper, which slashes and potentially jails validators as soon as their missed vote count exceeds the threshold where they can no longer meet the minimum valid vote rate for the window. This method is called every 7200 blocks (approx 12h), in addition to the existing end-of-window slashing. [1] [2]