elf: unwrap Typedef qualifiers in map field type assertions#1974
Open
joaquinhuigomez wants to merge 1 commit intocilium:mainfrom
Open
elf: unwrap Typedef qualifiers in map field type assertions#1974joaquinhuigomez wants to merge 1 commit intocilium:mainfrom
joaquinhuigomez wants to merge 1 commit intocilium:mainfrom
Conversation
Zig-compiled BPF objects wrap map definition struct members in BTF Typedef types (e.g. Typedef -> Pointer -> Array), causing type assertions on Pointer to fail. Use btf.UnderlyingType() to strip qualifiers before asserting on key, value, and uintFromBTF types. Fixes cilium#1972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zig-compiled BPF objects wrap map definition struct members in BTF Typedef types, causing type assertions on Pointer to fail during
LoadCollectionSpec. Usebtf.UnderlyingType()to strip qualifiers before asserting on key, value, anduintFromBTFtypes.Fixes #1972