ringbuf: add zero-copy read with deferred consumer advancement#1968
Open
orishuss wants to merge 1 commit intocilium:mainfrom
Open
ringbuf: add zero-copy read with deferred consumer advancement#1968orishuss wants to merge 1 commit intocilium:mainfrom
orishuss wants to merge 1 commit intocilium:mainfrom
Conversation
2c99f76 to
da08000
Compare
Signed-off-by: Ori Shussman <orishuss@gmail.com>
da08000 to
609e92e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ReadZeroCopyandCommittoringbuf.Reader, enabling zero-copy reads from the mmap'd ring buffer with batched consumer position advancement.Motivation
ReadIntocopies every record from mmap into a user buffer and advances the consumer position per-record via atomic store. In high-throughput scenarios (100K+ events/sec), the memmove and per-record atomics become a measurable CPU cost.This change allows callers to:
CommitChanges
Reader.ReadZeroCopy(rec *Record) error— setsrec.RawSampleto a slice of the mmap'd ring, does not advance consumer positionReader.Commit()— single atomic store to release all consumed spacereadRecordrefactored to delegate toreadRecordZeroCopy+ copy + advance (no duplication)ReadIntoandReadZeroCopyshare poll logic viareadWaithelperringReaderdelegation (same as Linux)API
Existing
Read/ReadIntosemantics are unchanged.Related
This PR differs by deferring consumer advancement, eliminating per-record atomic stores in addition to the copy.