Open
Conversation
leMaik
reviewed
Oct 27, 2024
| hit = waterPlaneIntersection(scene, ray) || hit; | ||
| } | ||
| if (scene.isGroundPlaneEnabled()) { | ||
| hit |= groundPlaneIntersection(scene, ray); |
Member
There was a problem hiding this comment.
This won't call the groundPlaneIntersection method if hit is already true, eg. if the water plane was hit before. If this gets fixed, we could have ocean grounds for water world mode. 🤩
Member
Author
There was a problem hiding this comment.
I think it should, |= uses the bitwise or operator so it can't get short circuited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an infinite ground plane similar to the water plane.
Currently the texture is set to stone and isn't configurable. Currently the controls are in the
Watertab so suggestions for a better place are welcome.