Skip to content

v1.1 Reader Experience: speckit planning, feature implementation, and comprehensive test coverage#26

Merged
chiga0 merged 8 commits intomainfrom
copilot/optimize-rss-reader-features
Mar 6, 2026
Merged

v1.1 Reader Experience: speckit planning, feature implementation, and comprehensive test coverage#26
chiga0 merged 8 commits intomainfrom
copilot/optimize-rss-reader-features

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 4, 2026

  • Add comprehensive tests for v1.1 Reader Experience features (unit, integration, e2e)
  • Fix CI failures (round 1): TypeScript error, perf test, E2E test
  • Fix CI failures (round 2): ESLint errors
    • Remove unused ANNOTATION_COLOR_CLASS top-level constant (duplicate of in-component annotationColorClass)
    • Remove unused rafCallback variable in useReadingProgress.test.ts
  • All 415 tests passing, TypeScript clean, ESLint clean (0 errors)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 4, 2026

Deploy Preview for rss-reader-pwa ready!

Name Link
🔨 Latest commit fa1c5da
🔍 Latest deploy log https://app.netlify.com/projects/rss-reader-pwa/deploys/69aa1f85455d400008e50fdc
😎 Deploy Preview https://deploy-preview-26--rss-reader-pwa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…w feature items

Co-authored-by: chiga0 <24784430+chiga0@users.noreply.github.com>
Copilot AI changed the title [WIP] Create detailed feature comparison report for RSS reader Add Medium vs RSS Reader feature comparison report and iteration plan Mar 4, 2026
Copilot AI and others added 2 commits March 5, 2026 05:08
…, tasks)

Co-authored-by: chiga0 <24784430+chiga0@users.noreply.github.com>
…ography, code copy, image lightbox, enhanced cards

Co-authored-by: chiga0 <24784430+chiga0@users.noreply.github.com>
Copilot AI changed the title Add Medium vs RSS Reader feature comparison report and iteration plan v1.1 Reader Experience: speckit planning + implementation of 6 reading UX features Mar 5, 2026
…tegration, e2e)

Co-authored-by: chiga0 <24784430+chiga0@users.noreply.github.com>
Copilot AI changed the title v1.1 Reader Experience: speckit planning + implementation of 6 reading UX features v1.1 Reader Experience: speckit planning, feature implementation, and comprehensive test coverage Mar 5, 2026
@chiga0
Copy link
Copy Markdown
Owner

chiga0 commented Mar 5, 2026

@copilot 修复测试和检查失败

…est for ReadingTimeResult, fix E2E test selector

Co-authored-by: chiga0 <24784430+chiga0@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 5, 2026

@copilot 修复测试和检查失败

Fixed in dcfc759. Three issues resolved:

  1. TypeScript error (annotationColorClass undefined) — The merge from main dropped this constant definition. Restored it.
  2. Perf test failurecalculateReadingTime now returns ReadingTimeResult object, updated assertion to use .minutes.
  3. E2E test failure — Feed detail page doesn't use ArticleItem (which has reading time), so removed the reading time card assertion from the E2E spec.

All 415 tests passing, TypeScript clean, CodeQL clean.

@chiga0
Copy link
Copy Markdown
Owner

chiga0 commented Mar 6, 2026

@copilot 修复单测

…nt errors

Co-authored-by: chiga0 <24784430+chiga0@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 6, 2026

@copilot 修复单测

Fixed in fa1c5da. Two ESLint errors resolved:

  1. Removed unused ANNOTATION_COLOR_CLASS top-level constant in ArticleDetailPage.tsx — was a duplicate of the in-component annotationColorClass that's actually used.
  2. Removed unused rafCallback variable in useReadingProgress.test.ts — was assigned in the rAF mock but never read.

All 415 tests passing, 0 ESLint errors.

@chiga0 chiga0 marked this pull request as ready for review March 6, 2026 04:38
@chiga0 chiga0 merged commit ca34d83 into main Mar 6, 2026
6 checks passed
@chiga0 chiga0 deleted the copilot/optimize-rss-reader-features branch March 6, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants