Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure musl compatibility in net_open_tcp2
This PR ensures musl compatibility in net_open_tcp2 by removing multi‑socket
return paths.
The packages required to compile on Alpine are build-base git mk-configure
mk-configure-dev libmaa-dev zlib-dev musl-dev
Changes to net_server.c/net_open_tcp2
rtmp renamed to ai
getaddrinfo() now uses:
(e.g., "10.x.x.x") is passed with AF_INET6.
Added detailed debug logging so socket selection and fallback
behavior are visible when running with -d.
Dual‑stack attempt (IPv6 with IPV6_V6ONLY=0) is still tried,
but, we fall back to separate IPv4 and IPv6 attempts.
dictd cannot safely handle multiple listening
sockets. The original code returned two sockets when dual‑stack
failed. This version ALWAYS returns exactly ONE socket:
Result:
with IPv4 and IPv6
Testing: