Fix undefined variable in README example code#62
Open
hobostay wants to merge 1 commit intochenglou:mainfrom
Open
Fix undefined variable in README example code#62hobostay wants to merge 1 commit intochenglou:mainfrom
hobostay wants to merge 1 commit intochenglou:mainfrom
Conversation
The example code in the "Measure a paragraph's height" section used an undefined variable `textWidth` which would cause a ReferenceError if run. Changed it to a concrete value (320) matching the other examples in the doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The example code in the "Measure a paragraph's height" section (line 28) used an undefined variable
textWidth:This would cause a
ReferenceError: textWidth is not definedif someone tries to run this code directly.Solution
Changed the undefined variable to a concrete value (320) to match the other examples in the documentation that use
320pxas the max width:This makes the example code immediately runnable without modification.
Testing
The fix is purely documentation-only. No code changes were made.