Add optional Playwright Chrome correctness driver#112
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHROME_AUTOMATION_DRIVER=playwrightRationale
We now have a mechanically checked-in Chrome correctness baseline in
corpora/chrome-step10.json, so we can evaluate a new browser driver by generating the same machine-readable sweep and diffing it directly.That made Chrome a good candidate for trying Playwright:
The important constraint is that this is only for correctness, not benchmarks.
During the investigation:
So this PR takes the conservative split:
Implementation notes
CHROME_AUTOMATION_DRIVER=playwright--screen-info={3024x1964 devicePixelRatio=2}foreground: true, so the Playwright path errors immediately thereVerification
bun run checkCHROME_AUTOMATION_DRIVER=playwright bun run accuracy-check→7680/7680CHROME_AUTOMATION_DRIVER=playwright bun run corpus-sweep --all --start=300 --end=900 --step=10 --output=/tmp/pretext-playwright-step10-pr.json/tmp/pretext-playwright-step10-pr.jsonagainstcorpora/chrome-step10.json→0diffsCHROME_AUTOMATION_DRIVER=playwright bun run benchmark-checkfails loudly with the expected guardrail messageFollow-up questions