Console mode fixes for Look mode cursor and text input#350
Open
joseph-hlucny wants to merge 2 commits intochaosforgeorg:developmentfrom
Open
Console mode fixes for Look mode cursor and text input#350joseph-hlucny wants to merge 2 commits intochaosforgeorg:developmentfrom
joseph-hlucny wants to merge 2 commits intochaosforgeorg:developmentfrom
Conversation
… modal popups (e.g. TMoreBeingView)
Author
|
I agree that Kornel Kisielewicz is the sole copyright holder of all contributions made in this PR and may use, modify, and distribute them freely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make the changes only have impact to the console mode version of the game. I felt this was a clean solution, but let me know if not.
Fix for Look mode cursor:
Behavior before:
When entering Look mode, cursor is not drawn.
Behavior after:
Cursor is drawn in Look mode, and does not show up in the More menu. Console cursor also does not show up in graphic version.
I think the issue might date back to d3c9390.
I believe the cursor was prevented from showing due to FLayers.IsEmpty resolving to False in Look mode.
Fix for text input not working (on character creation):
Behavior before:
Character creation naming would not accept text input.
Behavior after:
Text input is accepted
Felt it was less confusing to override in src/drltextio.pas instead of making the fix in src/vio.pas directly.
Tested on Windows 11.