Added module: command-dispatcher, allows shell commands to be run#126
Open
SimonThalvorsen wants to merge 1 commit intocfengine:masterfrom
Open
Added module: command-dispatcher, allows shell commands to be run#126SimonThalvorsen wants to merge 1 commit intocfengine:masterfrom
SimonThalvorsen wants to merge 1 commit intocfengine:masterfrom
Conversation
1351f3a to
bae2036
Compare
larsewi
requested changes
Mar 2, 2026
Contributor
larsewi
left a comment
There was a problem hiding this comment.
Please check (if you have not already) how the README.md of other modules are written and try to make it consistent. You can use this module as a template https://github.com/cfengine/modules/blob/master/promise-types/git/README.md
Comment on lines
+3
to
+4
| Internally these commands are ran using the `"useshell"`-promise based | ||
| on the `condition`-variable. |
Contributor
There was a problem hiding this comment.
Suggested change
| Internally these commands are ran using the `"useshell"`-promise based | |
| on the `condition`-variable. | |
| Internally these commands are ran using the `"useshell"`-promise based on the `condition`-variable. |
|
|
||
| `command` - The command to run | ||
|
|
||
| `condition` - Condition for running e.g `linux`, `debian`, etc. Defaults to `"any"` |
Contributor
There was a problem hiding this comment.
Suggested change
| `condition` - Condition for running e.g `linux`, `debian`, etc. Defaults to `"any"` | |
| `condition` - Condition for running. Use a class expression (e.g., `linux|bsd`). Defaults to `"any"` |
|
|
||
| `condition` - Condition for running e.g `linux`, `debian`, etc. Defaults to `"any"` | ||
|
|
||
| `ifelapsed` - Number of minutes between assessments. Defaults to 5 |
Contributor
There was a problem hiding this comment.
Suggested change
| `ifelapsed` - Number of minutes between assessments. Defaults to 5 | |
| `ifelapsed` - Number of minutes between assessments. Defaults to 5 minutes. |
Comment on lines
+17
to
+25
| ``` | ||
| ... | ||
| { | ||
| "command": "echo \"Hello World\"", | ||
| "condition": "linux", | ||
| "ifelapsed": "5" | ||
| }, | ||
| ... | ||
| ``` |
Contributor
There was a problem hiding this comment.
Suggested change
| ``` | |
| ... | |
| { | |
| "command": "echo \"Hello World\"", | |
| "condition": "linux", | |
| "ifelapsed": "5" | |
| }, | |
| ... | |
| ``` | |
| ```json | |
| ... | |
| { | |
| "command": "echo \"Hello World\"", | |
| "condition": "linux", | |
| "ifelapsed": "5" | |
| }, | |
| ... |
Comment on lines
+26
to
+27
| Would echo "Hello world" on every linux devices in 5 minute intervals. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| Would echo "Hello world" on every linux devices in 5 minute intervals. | |
| Would echo "Hello world" on every linux devices in 5 minute intervals. |
Contributor
6b3a82e to
cd19946
Compare
Ticket: CFE-4627 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
cd19946 to
ba76e30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-4627