Conversation
|
Hi @Tejas7007 Tejas, please make sure to not commit all the ruby related stuff (we probably should've added that to the gitignore). The commit right now changes >5000 files and it's unwieldy. Can you please remove everything unrelated to the website frontend? There should be ~10 files changed, not thousands. Thanks!! |
|
@arthur-lin1027 I think it should be good now |
arthur-lin1027
left a comment
arthur-lin1027
left a comment
There was a problem hiding this comment.
Overall I think it's fine. My local install of ruby is messed up so I still need to some time to see how the website looks when rendered, but there are a few more extraneous files to delete.
|
@arthur-lin1027 the duplicated files have been deleted..Sorry for that.. |
arthur-lin1027
left a comment
arthur-lin1027
left a comment
There was a problem hiding this comment.
I have one last change for you to do. Then, I think we're set!
There was a problem hiding this comment.
/assets/img/tejas_dahiya.png no longer exists and so the webpage doesn't render it properly. Since I think it was exactly the same as /assets/img/tejas_dahiya_2.png, you could probably just use that image.
arthur-lin1027
left a comment
arthur-lin1027
left a comment
There was a problem hiding this comment.
Please delete upstream and SSH
|
@Tejas7007 All good! Make sure to "Squash and merge" so that all your commits in this branch get squashed into a single commit. |
2 participants
Hi @rosecers and @arthur-lin1027 , could you please review this PR? It adds my member page, headshot, and updates members.txt. Thanks!