Skip to content

Create publications.yml#73

Merged
rosecers merged 8 commits intomainfrom
rosecers-patch-3
Jun 5, 2025
Merged

Create publications.yml#73
rosecers merged 8 commits intomainfrom
rosecers-patch-3

Conversation

@rosecers
Copy link
Copy Markdown
Contributor

@rosecers rosecers commented Jun 5, 2025

No description provided.

@rosecers rosecers marked this pull request as draft June 5, 2025 15:05
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 5, 2025

🚀 Preview your site is ready:
https://cersonsky-lab.github.io/website-previews/pr-73

@rosecers rosecers force-pushed the rosecers-patch-3 branch 4 times, most recently from c31434a to d3bb04f Compare June 5, 2025 16:48
@rosecers rosecers marked this pull request as ready for review June 5, 2025 16:50
@rosecers rosecers requested a review from arthur-lin1027 June 5, 2025 16:50
@rosecers rosecers force-pushed the rosecers-patch-3 branch from d684991 to c1b42b0 Compare June 5, 2025 19:10
@rosecers rosecers force-pushed the rosecers-patch-3 branch from dc60365 to 940ac31 Compare June 5, 2025 19:11
@rosecers rosecers force-pushed the rosecers-patch-3 branch from 1bd18fd to 55fa773 Compare June 5, 2025 19:16
@rosecers rosecers force-pushed the rosecers-patch-3 branch from 732c18b to 36da759 Compare June 5, 2025 19:24
Copy link
Copy Markdown
Contributor

@arthur-lin1027 arthur-lin1027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be somewhat improved by changing the styling and reducing the bolding. Maybe we can follow the ACS style guide? https://pubs.acs.org/doi/full/10.1021/acsguide.40303

Some examples:
Shuwen: https://yuegroup.cbe.cornell.edu/papers/
Michele: https://www.epfl.ch/labs/cosmo/index-html/publications/
Voth: https://voices.uchicago.edu/vothgroup/publications/

python-version: '3.x'

- name: Install dependencies
run: pip install requests
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also pip install pyzotero?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Charles and I both think there's too much bolded text in each entry, it's a bit visually striking.

Maybe consider italicizing the journal name rather than bolding it? Or, we could follow the formatting of a specific style guide like ACS (https://pubs.acs.org/doi/full/10.1021/acsguide.40303)

@rosecers
Copy link
Copy Markdown
Contributor Author

rosecers commented Jun 5, 2025

@arthur-lin1027 @cbefan, check the new preview (https://cersonsky-lab.github.io/website-previews/pr-73/publications/) and see if it's to your liking.

@arthur-lin1027 arthur-lin1027 self-requested a review June 5, 2025 22:13
@arthur-lin1027
Copy link
Copy Markdown
Contributor

I like it!

@rosecers rosecers merged commit 975b8f3 into main Jun 5, 2025
2 checks passed
@cbefan
Copy link
Copy Markdown
Contributor

cbefan commented Jun 5, 2025

Looks good to me, although I agree bolding the titles might be a bit much. Maybe just bold group members' names? I think it's good regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants