Conversation
-added Education testing into `PersonTest.java` -added appropriate resetting of `eduLeaveSchoolFlag` and `eduExitSampleFlag` -inSchoolAlignment was missing the necessary student share targets (they're now added into `policy parameters.xlsx`) -updated `time_series_factor.xlsx` to include "UK_students_adjustment" -aaded resetting of the `eduLeaveSchoolFlag` into `leavingSchool()` -added updated of the `eduExitSampleFlag`
…the EU models as part of the ESPON project which is now closed
-ensure ACMales, ACFemales and SingleDepMlaes, SingleDepFemales employment rates are aligned correctly
…ategories. Integration test is passed.
…ntAlignment Made necessary updates to the employment alignment
eduHighestC4 demPartnerStatus
- Update of the README.md file - Sort the codebook in alphabetical order
- Remove sIndex and sIndexNormalised - Rename lifetimeIncome --> yLifeTime, according to the new naming convention
…the JAS-MINE core already update regression coefficient during employment alignment, hence I remove refreshLabourSupplyUtilityRegression(...) method in the Parameters class.
… little bit - Employment alignment now warm-starts from previous year’s solved adjustment when year > startYear; otherwise it uses current-year configured value. - Added inline comments explaining purpose and behaviour.
-updated inSchool and Partnership target inline with new initial populations -Partnership targets are now loaded from partnered_share_targets.xlsx. -inSchoolAlignment, PartnershipAlignment, FertilityAlignment now use last year Adjustment parameter for a start and also even when alignment process ends (e.g, after 2023 due to lack of target data), the relevant processes (inSchool, Partnership, Fertility) apply this "frozen" adjustment parameter. -adjusted RootSearch exit parameters
…V-correct-alignments Updated alignment details
This is the branch to be used for the release. The PCM estimates must be used on a separate one.
…S_EmpAlign_Check Updated employment alignment targets file, employment_targets.xlsx
Resampling: off Population alignment: on (from year 0) Cohabitation alignment: on (from year 1) All other alignments off
…V-fix-small-bug-partneredTarget Fixed a small bug in partnership targets
Update training populations
Issue at the DB building phase with the previous setting (private boolean useWeights = true).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new_estimatesis the branch where all the changes for the new release were made.