Update wxWidgets to 3.3.2 (stable) for vcpkg#1824
Open
Crementif wants to merge 2 commits intocemu-project:mainfrom
Open
Update wxWidgets to 3.3.2 (stable) for vcpkg#1824Crementif wants to merge 2 commits intocemu-project:mainfrom
Crementif wants to merge 2 commits intocemu-project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we had our wxWidgets version pinned to a specific commit on the main branch due to us needing some upstreamed fixes to add proper dark mode support. Unfortunately, later commits rewrote some of the behavior to fix other issues, but reintroduced some regressions that caused issues, and hence why we weren't able to pin a newer version.
Now that I've found a fix for some of the unintended regressions (it turned out to require working around the win32 ListCtrl even more due to it calculating the width of columns in a very strange way), I've added it to our vcpkg overlay while it gets upstreamed and merged into another stable release.
This stable 3.3.2 version of wxWidgets has some nice fixes for the dark mode, which are also very welcome. I'm also hoping that it might address some of the Mac issues we've been seeing, but testing is very welcome!