fix: handle missing sign parameter in EPay notify callback#852
Open
onesyue wants to merge 1 commit intocedar2025:masterfrom
Open
fix: handle missing sign parameter in EPay notify callback#852onesyue wants to merge 1 commit intocedar2025:masterfrom
onesyue wants to merge 1 commit intocedar2025:masterfrom
Conversation
PHP 8 throws ErrorException for undefined array keys. When the POST body is lost through CDN/proxy layers (e.g., Cloudflare), the request input may be empty, causing $params['sign'] to throw an exception. This results in 500 errors and the payment gateway retrying indefinitely. Use null coalescing operator and return false early to gracefully reject invalid callbacks without triggering an exception. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorException: Undefined array key "sign"when accessing$params['sign']on an empty/incomplete POST body$request->input()returns an empty array??) and returnfalseearly to gracefully reject invalid callbacksChanges
plugins/Epay/Plugin.phpline 82:Test plan
falseinstead of 500signkey returnsfalseinstead of throwing exception🤖 Generated with Claude Code