feat: return online_count in user subscription API#820
Open
onesyue wants to merge 1 commit intocedar2025:masterfrom
Open
feat: return online_count in user subscription API#820onesyue wants to merge 1 commit intocedar2025:masterfrom
onesyue wants to merge 1 commit intocedar2025:masterfrom
Conversation
The online_count column already exists in the v2_user table but was not included in the getSubscribe() select list, preventing frontends from displaying the user's current online device count. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
online_countto the->select([...])array in thegetSubscribe()method ofUserController.phponline_countcolumn already exists in thev2_usertable but was not included in the query, so it was never returned in the subscription API responseTest plan
GET /api/v1/user/getSubscribenow includesonline_countin the response🤖 Generated with Claude Code