Open
Conversation
…le path need be shown in the console.
…f count, use array_map instead of foreach, call isset with multiple args
|
Hi @okonomiyaki3000 , thanks a lot for the base_path, and all the refactor ! |
|
I'm seriously thinking about including this in my fork of chromephp. Do you still want to support this PR after literally 5 years of nothing? |
|
This PR looks good for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This request incorporates my other recent PRs as well as a major change to using the magic methods
__calland__callStaticto do everything. I noticed that every function was doing the same thing so I figured they could all be easily replaced. So, if this request is cool (I think it's pretty cool), please ignore the others.