use PHP_VERSION and version_compare() where appropriate#44
Open
okonomiyaki3000 wants to merge 1 commit intoccampbell:masterfrom
Open
use PHP_VERSION and version_compare() where appropriate#44okonomiyaki3000 wants to merge 1 commit intoccampbell:masterfrom
okonomiyaki3000 wants to merge 1 commit intoccampbell:masterfrom
Conversation
DanMan
approved these changes
Feb 2, 2017
Author
|
Thanks @DanMan This is a great library but has it been abandoned? |
|
YW @okonomiyaki3000 . Judging from the commit history, yes. Maybe you can put your fork on packagist.org ? I think it might be the most complete. It's a shame that this isn't a drop-in replacement for FirePHP. At least the enable/disable switch would be very useful. I've currently wrapped this one in another shallow class of my own to accomplish that. |
|
@okonomiyaki3000 I merged this PR into my own fork of chromephp so that your work wouldn't be completely in vain. But honestly? comparing PHP 5.3 and 5.1? Damn, this code has rotted! I scarcely even remember the days when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to store
$_php_versionbecause there is alreadyPHP_VERSION.version_compare()is the correct way to compare or test version numbers.Also, I didn't remove it here, but
$_timestampseems to be unused. Do we actually need this value for any reason?