Open
Conversation
TODO: revert this commit prior to merge request
It's probably not one of the first that a user might reach for.
Owner
|
Sorry, I completely missed this until now! |
Owner
|
@icmurray Sorry for the slow review. This looks great. Is there a reason why it’s still a draft PR? Are you still working on it? |
Contributor
Author
|
@cb372 thanks for reviewing! I left the PR in a draft state because I had the niggling feeling that something was missing! But it's not come to me, so I guess either it's good enough or it wasn't important. |
Contributor
|
My drive-by, unsolicited suggestion: assume good intentions and merge. "Merge first and ask questions later", if you will. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I implemented the
apSfunction from the paper. I wasn't sure if it was deliberately omitted or not? Maybe because you had in mind modelling rigid and non-rigid Selectives separately, or perhaps there was some other reason?If you think this might be a useful contribution, let me know and I'll expand on the testing a little further before submitting something for review. But if not, don't feel obliged: I'm just satisfying my own curiosities!