Skip to content

fix(vim.pack): error if git is not installed#995

Merged
sgoudham merged 1 commit intocatppuccin:mainfrom
mrcjkb:mj/push-zktstuuknvwl
Apr 6, 2026
Merged

fix(vim.pack): error if git is not installed#995
sgoudham merged 1 commit intocatppuccin:mainfrom
mrcjkb:mj/push-zktstuuknvwl

Conversation

@mrcjkb
Copy link
Copy Markdown
Contributor

@mrcjkb mrcjkb commented Apr 6, 2026

Problem

vim.pack.get() will throw an error if Git is not installed (Neovim 0.12.1).

Solution

Wrap the vim.pack plugin detection in a pcall.

@comfysage
Copy link
Copy Markdown
Collaborator

thnx . didnt think that would be required there.

Copy link
Copy Markdown
Collaborator

@comfysage comfysage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd rather the vim.pack.get is pcalled and and the error is returned in a warning

@mrcjkb mrcjkb force-pushed the mj/push-zktstuuknvwl branch from 1a6a260 to 241b9f7 Compare April 6, 2026 19:14
@mrcjkb
Copy link
Copy Markdown
Contributor Author

mrcjkb commented Apr 6, 2026

i'd rather the vim.pack.get is pcalled and and the error is returned in a warning

Done. I've also passed in { info = false } to prevent it from trying to use Git to get additional info that isn't used by catppuccin.nvim.

@mrcjkb mrcjkb force-pushed the mj/push-zktstuuknvwl branch from 241b9f7 to 19067f5 Compare April 6, 2026 19:28
@sgoudham sgoudham changed the title fix: error if git is not installed fix(vim.pack): error if git is not installed Apr 6, 2026
@sgoudham sgoudham merged commit 0de2b6d into catppuccin:main Apr 6, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants