Remove unused RichText import to fix CI lint failure#1346
Merged
captbaritone merged 1 commit intomasterfrom Mar 25, 2026
Merged
Remove unused RichText import to fix CI lint failure#1346captbaritone merged 1 commit intomasterfrom
captbaritone merged 1 commit intomasterfrom
Conversation
The RichText import from @atproto/api was unused after refactoring the Bluesky posting logic to use manual facets instead of RichText helpers. This caused the ESLint no-unused-vars rule to fail in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Size Change: 0 B 🆕 Total Size: 0 B |
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RichTextimport frompackages/skin-database/tasks/bluesky.tsRichTexthelper classno-unused-varsrule was flagging this as an error, causing the CI lint step to failRoot Cause
The commit "Consolidate bluesky posts" (247bda1) refactored the Bluesky posting code to build rich text facets manually using
AppBskyRichtextFacet.Main[]instead of using theRichTexthelper. TheRichTextimport was not cleaned up at that point.Test Plan
pnpm --filter skin-database lintpasses locally with no errorsGenerated with Claude Code