修正：pc处理逻辑；新增：跳转指令(if_cmple, goto)+iload_n指令#9
Open
huangwei2013 wants to merge 9 commits intocaoym:masterfrom
Open
修正：pc处理逻辑；新增：跳转指令(if_cmple, goto)+iload_n指令#9huangwei2013 wants to merge 9 commits intocaoym:masterfrom
huangwei2013 wants to merge 9 commits intocaoym:masterfrom
Conversation
2.opcode/OpcodeRout.java - 增加 lload_0 ~ lload_3 的实现 - AALOAD 的处理，加上安全判断处理(否则，运行sample2会在这报错) 3.Slots* 增加提示
2.opcode/OpcodeRout.java：增加 arraylength 实现
2.opcode/OpcodeRout.java：增加跳转opcode实现-if_cmple、goto，但还有问题 3.增加samples代码
2.更新ReadMe.md
caoym
reviewed
Jun 19, 2019
README.md
Outdated
| 这是一个Java实现的JAVA虚拟机，它会非常简单，实际上简单的只够运行HelloWorld。虽然简单，但尽量符合 JVM 标准，目前主要参考依据是[《Java虚拟机规范 （Java SE 7 中文版）》](http://www.iteye.com/topic/1117824)。 | ||
|
|
||
| 关于此项目的说明，[详见此文](http://www.jianshu.com/p/4d81465c2fb8)。 | ||
| 非原创，原项目来自 https://github.com/caoym/jjvm ， |
Collaborator
There was a problem hiding this comment.
此处说明可以删除，否则合入后会比较奇怪
另外后面的参考资料，建议不要放到readme内，因为本项目创建过程中并没有参考这两个项目。建议在修改pc实现处可以注明参考资料。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#修正pc处理逻辑
不兼容原处理模式
#新增指令
##跳转指令
if_cmple, goto
##加载指令
iload_n
#sample代码(1~3)