This repository was archived by the owner on Feb 3, 2020. It is now read-only.
Dont overwrite Headers written by response.setHeader#15
Open
jenshimmelreich wants to merge 8 commits intocaolan:masterfrom
Open
Dont overwrite Headers written by response.setHeader#15jenshimmelreich wants to merge 8 commits intocaolan:masterfrom
jenshimmelreich wants to merge 8 commits intocaolan:masterfrom
Conversation
added 8 commits
August 17, 2011 14:46
|
+1 When I try and set another cookie in my app that is unrelated to the session cookie, it doesn't make it past the cookie-sessions' writeHead function which makes it impossible for me to use normal cookies in addition to the session cookies provided by cookie-sessions. |
|
are you going to solve this issue? |
|
Just to let you know that I just installed Jens forked project and testing it. If I have any issues I will let you know. It would be nice if you can include his changes to the next release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original module modifies response.writeHead to include the cookie-Header. The Headers which are setted by response.setHeader won't be arguments to writeHead. If another session is setted by setHeader, it will be lost. This patch adds the session cookie to other cookies, which would be setted by setHeader.