Skip to content

fix(go.mod): fix module path#281

Merged
niemeyer merged 1 commit intocanonical:masterfrom
holmanb:holmanb/fix-go-install
Mar 23, 2026
Merged

fix(go.mod): fix module path#281
niemeyer merged 1 commit intocanonical:masterfrom
holmanb:holmanb/fix-go-install

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Mar 12, 2026

Fixes #240
Fixes #267

@holmanb holmanb force-pushed the holmanb/fix-go-install branch from 1c40c34 to 6fb7277 Compare March 12, 2026 21:01
@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Mar 17, 2026

Note to reviewers: Install documentation was broken by the change from #238. This updates the code to match the documentation.

An alternative proposal, #260 reverts the offending commit - however this doesn't address other issues related to printing links that 404.

Copy link
Copy Markdown
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these.

@niemeyer niemeyer merged commit a3a44a9 into canonical:master Mar 23, 2026
1 check failed
@holmanb holmanb deleted the holmanb/fix-go-install branch March 23, 2026 17:19
@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Mar 23, 2026

With the updated go.mod, the documented install command now works:

$ go install github.com/canonical/spread/cmd/spread@latest
go: downloading github.com/canonical/spread v0.0.0-20260323164801-a3a44a96b6d0
go: downloading github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e
go: downloading golang.org/x/oauth2 v0.25.0
go: downloading github.com/go-goose/goose/v5 v5.0.0-20230421180421-abaee9096e3a
go: downloading golang.org/x/net v0.38.0
go: downloading golang.org/x/crypto v0.36.0
go: downloading golang.org/x/term v0.30.0
go: downloading gopkg.in/tomb.v2 v2.0.0-20161208151619-d5d1b5820637
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading golang.org/x/sys v0.31.0
go: downloading cloud.google.com/go/compute/metadata v0.3.0
go: downloading github.com/kr/text v0.2.0
go: downloading github.com/juju/collections v0.0.0-20220203020748-febd7cad8a7a

Thanks for fixing these.

Welcome, and thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: fix path for go install Default install location doesn't work

2 participants