chore: bump pygments, requests, and cryptography versions#2404
Open
tonyandrewmeyer wants to merge 2 commits intocanonical:mainfrom
Open
chore: bump pygments, requests, and cryptography versions#2404tonyandrewmeyer wants to merge 2 commits intocanonical:mainfrom
tonyandrewmeyer wants to merge 2 commits intocanonical:mainfrom
Conversation
This was referenced Mar 30, 2026
tonyandrewmeyer
changed the title
james-garner-canonical
approved these changes
Mar 30, 2026
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
Thanks for taking care of this. I guess we can discuss whether to wait in daily.
dwilding
approved these changes
Mar 30, 2026
Contributor
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
I guess we ought to bump pygments in the Charmcraft profiles too? I can take care of that.
5 tasks
Contributor
|
FYI here's the corresponding Charmcraft PR: canonical/charmcraft#2622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pygments is used by pytest. This release fixes a security issue, but does have other changes (dropping Python 3.8 support, and a bunch more). See #2403 for more details. The security issue is not one that we are likely to be impacted by, but we might as well move to the new version, particularly since this is a CI/dev dependency.
Also bumps requests, which has another security issue that would also not impact us.
Also bumps cryptography, which has another security issue that as far as I can tell, likely also does not impact us.
(We could wait a week before merging this if we decided that was safer.)