Skip to content

Add L2TP support#114

Open
lxnt wants to merge 3 commits intocanonical:mainfrom
lxnt:l2tp
Open

Add L2TP support#114
lxnt wants to merge 3 commits intocanonical:mainfrom
lxnt:l2tp

Conversation

@lxnt
Copy link
Contributor

@lxnt lxnt commented Dec 4, 2019

Description

Adds L2TP support.

Rework of #82

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Closes an open bug in Launchpad.

@codecov-io
Copy link

codecov-io commented Dec 4, 2019 •
edited
Loading

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #114    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          36     36            
  Lines        4131   4260   +129     
======================================
+ Hits         4131   4260   +129
Impacted Files Coverage Δ
src/validation.c 100% <100%> (ø) ⬆️
src/parse.c 100% <100%> (ø) ⬆️
tests/generator/test_tunnels.py 100% <100%> (ø) ⬆️
src/networkd.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ac74f...970d97e. Read the comment docs.

cyphermox
cyphermox suggested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@cyphermox cyphermox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked vorlon to give his review specific to the naming of new keys and how this fits in a broader view of the netplan syntax.

src/parse.c Outdated
{"keys", YAML_NO_NODE, handle_tunnel_key_mapping},

/* l2tp; reuses tunnel.local_ip and tunnel.remote_ip*/
{"local_tunnel_id", YAML_SCALAR_NODE, handle_netdef_guint, NULL, netdef_offset(l2tp.local_tunnel_id)},
Copy link
Contributor

@cyphermox cyphermox Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names for keys are typically split with hyphen rather than underscore. Could you please adjust that so things are at least consistent in that regard?

Copy link
Contributor Author

@lxnt lxnt Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, how could I miss that.
Done.

stappersg
stappersg reviewed Dec 26, 2019
View reviewed changes
@slyon slyon added enhancement New feature or request schema change This PR includes a change to netplan's YAML schema, which needs sign-off labels Apr 27, 2020
@slyon slyon added the community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. label Aug 16, 2023
@david-barbion
Copy link

david-barbion commented Dec 1, 2023

Would be great to have this long awaiting feature 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vorlonofportland vorlonofportland Awaiting requested review from vorlonofportland

2 more reviewers

@stappersg stappersg stappersg left review comments

@cyphermox cyphermox cyphermox requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. enhancement New feature or request schema change This PR includes a change to netplan's YAML schema, which needs sign-off

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lxnt @codecov-io @david-barbion @cyphermox @stappersg @slyon