feat: add ui parameter to all add_info functions#561
Open
bdrung wants to merge 1 commit intocanonical:mainfrom
Open
feat: add ui parameter to all add_info functions#561bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung wants to merge 1 commit intocanonical:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 84.41% 84.41%
=======================================
Files 104 104
Lines 20901 20901
Branches 3265 3265
=======================================
Hits 17644 17644
- Misses 2817 2818 +1
+ Partials 440 439 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`_run_hook` calls the `add_info` functions with two parameters and falls back to one parameter for backward compatibility. So add the second `ui` parameter to all `add_info` functions. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_run_hookcalls theadd_infofunctions with two parameters and falls back to one parameter for backward compatibility. So add the seconduiparameter to alladd_infofunctions.