report: remove trailing newlines from traceback#559
Open
bdrung wants to merge 1 commit intocanonical:mainfrom
Open
report: remove trailing newlines from traceback#559bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung wants to merge 1 commit intocanonical:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=======================================
Coverage 84.41% 84.42%
=======================================
Files 104 104
Lines 20910 20910
Branches 3275 3275
=======================================
+ Hits 17651 17653 +2
+ Misses 2819 2817 -2
Partials 440 440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdrung
force-pushed
the
strip-traceback
branch
2 times, most recently
from
618d041 to
270ad66
Compare
In case `add_info` fails, the hook error will be added to the report. This traceback has a trailing newline which can break the report file. So strip leading and trailing whitespaces from the traceback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case
add_infofails, the hook error will be added to the report. This traceback has a trailing newline which can break the report file. So strip leading and trailing whitespaces from the traceback.