fix(xml): add escaping, root element, and pretty printing#20
fix(xml): add escaping, root element, and pretty printing#20calebevans merged 2 commits intomainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughVersion 0.3.3 updates the XML output formatter to emit a pretty-printed XML document with an XML declaration and an Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/architecture.md`:
- Around line 307-334: The XML example in the <anomalies> <block> section has
several log lines (the ones showing "[Sun Dec 04 14:29:00 2005] ..." through
"[Sun Dec 04 16:24:06 2005] ...") that are missing the 4-space indentation used
for other lines inside the <block>; update those lines so each line within the
<block> is prefixed with four spaces to match the surrounding entries and
maintain consistent indentation.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/cordon/postprocess/formatter.py`:
- Around line 55-71: The current indentation logic drops whitespace-only lines
because it uses line.strip(); update the generator that builds indented_content
to preserve original whitespace-only lines by checking for an empty string
instead (e.g., use if line != "" or if line == "" accordingly) so that
escaped_content.splitlines() entries that contain only whitespace are not
discarded; modify the expression that creates indented_content (referencing
escaped_content and indented_content) to prepend the indentation to non-empty
strings and preserve whitespace-only lines from content_lines when appending to
output_parts.
- Add XML special character escaping (&, <, >) to prevent parse errors - Add proper XML declaration and <anomalies> root element - Add pretty printing with indentation for readability - Add test coverage for XML escaping - Update documentation to reflect new XML structure
|



Summary by CodeRabbit
Documentation
Bug Fixes
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.