Skip to content
This repository was archived by the owner on Jan 6, 2020. It is now read-only.

FIX: support utf-8 string#14

Open
snow wants to merge 1 commit intocaiges:masterfrom
snow:master
Open

FIX: support utf-8 string#14
snow wants to merge 1 commit intocaiges:masterfrom
snow:master

Conversation

@snow
Copy link
Copy Markdown

@snow snow commented Jun 16, 2016

No description provided.

@snow
Copy link
Copy Markdown
Author

snow commented Jun 16, 2016

test fails, please wait for me fixing it.

@yob
Copy link
Copy Markdown
Collaborator

yob commented Jun 16, 2016

I'm not totally across the RC4 algorithm, but is this definitely what should be done?

If anything, I'd have guessed force_encoding('binary'). unpack('C*') might be the best way to ensure comparability with any input encoding.

@snow
Copy link
Copy Markdown
Author

snow commented Jun 16, 2016

If anything, I'd have guessed force_encoding('binary'). unpack('C*') might be the best way to ensure comparability with any input encoding.

I'll try it when I'm free. Thank you for suggestion.

@yob
Copy link
Copy Markdown
Collaborator

yob commented Jun 16, 2016

Good luck!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants