tests(nmrs): .ovpn parser tests and refactored logic in arms#316
Open
cachebag wants to merge 24 commits intodev-openvpnfrom
Open
tests(nmrs): .ovpn parser tests and refactored logic in arms#316cachebag wants to merge 24 commits intodev-openvpnfrom
.ovpn parser tests and refactored logic in arms#316cachebag wants to merge 24 commits intodev-openvpnfrom
Conversation
cachebag
added
nmrs
cachebag
force-pushed
the
ovpn-parser
branch
2 times, most recently
from
3fec0bf to
78d866a
Compare
… openvpn connections
…connect_vpn, FIXME in get_vpn_info, update wireguard peers comment, reverted back to body.deserialize()? in forget_vpn,
…nConfig for WireGuardConfig, and VpnConfig for VpnCredentials. Also removed OpenVpn from the VpnType enum.
Owner
Author
|
Fuck you clippy we're in dev SemVer check can also fail right now, we do not concern ourselves with API stability in a dev branch |
cachebag
force-pushed
the
dev-openvpn
branch
2 times, most recently
from
c1acdfe to
5d65aa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a suite of unit tests for the parsing logic and refactors some of the parsing logic to follow some rust idioms.